[vs17.7] Backward-compatibility with KeyValuePair<string, string> metadata items [#8864] #8978
Conversation
|
Hello! I noticed that you're targeting one of our servicing branches. Please consider updating the version. |
eng/Versions.props
Outdated
There was a problem hiding this comment.
I'm tempted to merge everything we want to take for 17.7 into a single .1 version bump, but that will be a bit of a hassle of manual work. We can also just follow the regular procedure. Preferences?
There was a problem hiding this comment.
I'd prefer to see separate PRs (easier for tracking/ reverting if anything).
Another option is to postpone VS insertions from 17.7, bump version once only after everything is in and resume
There was a problem hiding this comment.
Offline agreement: let's keep all 17.7 PRs open and then we (== @rainersigwald) will perform octopus merge or a succession of merges (with VS insertions paused) followed by a single version bunp
I removed the last commit - but intentionally keeping the conversation open to prevent accidental merges.
JanKrivanek
force-pushed
the
backport/pr-8870-to-vs17.7
branch
from
92901f0 to
9e5717b
Compare
|
Hello! I noticed that you're targeting one of our servicing branches. Please consider updating the version. |
rainersigwald
force-pushed
the
backport/pr-8870-to-vs17.7
branch
from
9e5717b to
8ebc5ca
Compare
rainersigwald
added
Servicing-approved
and removed
Servicing-consider
do-not-merge
labels
Summary
Fixes regression (#8864) that prevents some older tasks from succeeding.
Customer Impact
Build breaks reported by external customer on upgrade to 17.6. No known workaround beyond "don't use affected tasks".
Regression?
Yes, from 17.5 via #8240 and #8646.
Testing
Automated tests and manual testing in the repro scenario.
Risk
Low--adds fallback to code that is almost identical to the pre-regression codepath when we can't use a newer bulk method.